Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gradle tasks related to zipping sample projects #215

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Add gradle tasks related to zipping sample projects #215

merged 1 commit into from
Oct 4, 2024

Conversation

devloglogan
Copy link
Collaborator

@m4gr3d mentioned that having the vendor repo's sample projects available on the asset library would be super handy for users of the XR Editor. I think it makes most sense to host the zips of these in the vendor repo releases. This PR adds some gradle tasks to generate/clean those.

I'll add the zipped projects to the 3.0.1 release if we agree on this approach.

@devloglogan devloglogan added the enhancement New feature or request label Oct 3, 2024
@devloglogan
Copy link
Collaborator Author

Fixed the zipSamples task to also include the root directory in the zip, rather than just the contents. I've attached zips of the samples to the 3.0.1 release.

@dsnopek
Copy link
Collaborator

dsnopek commented Oct 4, 2024

Thanks!

For the most part, this looks good.

However, taking a peek at the ZIP files that were added to the release, they included the android/ directory, which shouldn't be included. That should be added by the version of Godot that the user has, and not be bundled with the project.

It'd be great if the gradle task could omit that directory? That way, we don't have to be careful about not including it.

@devloglogan
Copy link
Collaborator Author

However, taking a peek at the ZIP files that were added to the release, they included the android/ directory, which shouldn't be included. That should be added by the version of Godot that the user has, and not be bundled with the project.

Ah, my mistake! Just updated the PR so the task removes those directories as well. Will update the release zips. Thanks!

m4gr3d
m4gr3d approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

dsnopek
dsnopek approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@m4gr3d m4gr3d merged commit f1f71de into GodotVR:master Oct 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

@dsnopek dsnopek dsnopek approved these changes

@BastiaanOlij BastiaanOlij Awaiting requested review from BastiaanOlij

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devloglogan @dsnopek @m4gr3d